config issue with 'Overwrite global config values'

[pollen8]

In the component control panel parameters options if you have 'Overwrite global config values' set to yes. This wil overwrite Joomla's config with the loaded Joomfish language parameters.

But if the active language has no translation from mailfrom or mailfromname in the langugage parameters (components->joomfish->language configuration then press the config button next to each language) Joomla's config values for those options are replaced with "".

This means that ANY other component trying to access those values get a blank string and can not send email :O

Surely it would be better to test if a translation has been set and then and only then use those values?

proposed fix:

plugins/system/jfrouter.php

replace line 350:

Code: Select all

$registry->setValue("config.".$key,$val);


with

Code: Select all

if (trim($val) !== '') {
   $registry->setValue("config.".$key,$val);
}


[alex]

Thx for the hint. Implemented in the latest trunk SVN, will be released with JF 2.1

Alex

[tkuschel]

Thank you pollen8, this post was quite long ago;

I had the problem, that my meta texts: meta name="keywords" as well as meta name="description" disappeared after installing the latest JoomFish 2.2.3 version (upgrade from 2.1.5).
I have changed your line - now the global configuration is not overridden when there is an empty value.
-- your suggestion is not implemented yet.
regards,
Thomas
http://www.loytec.com

[alex]

Looks like this was lost in the migration to github.

Fixed again:
https://github.com/JoomFish/jf-core/issues/8